Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: NilResettingTimer.Time() should execute the timed function #27724

Merged
merged 1 commit into from
Jul 14, 2023
Merged

metrics: NilResettingTimer.Time() should execute the timed function #27724

merged 1 commit into from
Jul 14, 2023

Conversation

omerfirmak
Copy link
Contributor

No description provided.

@omerfirmak
Copy link
Contributor Author

omerfirmak commented Jul 14, 2023 •
edited
Loading

Missed this in #27723 @fjl

fjl
fjl approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@fjl fjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@fjl fjl merged commit 34d5072 into ethereum:master Jul 14, 2023
@fjl fjl added this to the 1.12.1 milestone Jul 14, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@omerfirmak @devopsbo3
metrics: NilResettingTimer.Time should execute the timed function (et…
041d64c 
…hereum#27724)
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "metrics: NilResettingTimer.Time should execute the timed func…
cc61ef3 
…tion (ethereum#27724)"

This reverts commit 041d64c.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "metrics: NilResettingTimer.Time should execute the timed func…
c4c1644 
…tion (ethereum#27724)"

This reverts commit 041d64c.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Dec 6, 2024
@omerfirmak @gzliudan
metrics: NilResettingTimer.Time should execute the timed function (et…
9917171 
…hereum#27724)
@gzliudan gzliudan mentioned this pull request Dec 10, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
@gzliudan
metrics: NilResettingTimer.Time should execute the timed function (et…
8c97430 
…hereum#27724)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
@gzliudan
metrics: NilResettingTimer.Time should execute the timed function (et…
382d196 
…hereum#27724)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 10, 2024
@gzliudan
metrics: NilResettingTimer.Time should execute the timed function (et…
ec73d87 
…hereum#27724)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 13, 2024
@gzliudan
metrics: NilResettingTimer.Time should execute the timed function (et…
d43f6c0 
…hereum#27724)
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 16, 2024
@gzliudan @JukLee0ira
metrics: NilResettingTimer.Time should execute the timed function (et…
f1944ed 
…hereum#27724)
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 16, 2024
@gzliudan @JukLee0ira
metrics: NilResettingTimer.Time should execute the timed function (et…
fb861f4 
…hereum#27724)
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 20, 2024
@gzliudan @JukLee0ira
metrics: NilResettingTimer.Time should execute the timed function (et…
2ef0ced 
…hereum#27724)
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 20, 2024
@gzliudan @JukLee0ira
metrics: NilResettingTimer.Time should execute the timed function (et…
894d543 
…hereum#27724)
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Dec 22, 2024
@gzliudan @JukLee0ira
metrics: NilResettingTimer.Time should execute the timed function (et…
8fad70e 
…hereum#27724)
JukLee0ira pushed a commit to JukLee0ira/XDPoSChain that referenced this pull request Jan 2, 2025
@gzliudan @JukLee0ira
metrics: NilResettingTimer.Time should execute the timed function (et…
78017f2 
…hereum#27724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@omerfirmak @fjl