Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, eth, miner: start propagating and consuming blob txs #28243

Merged
merged 7 commits into from
Oct 4, 2023
Merged

core, eth, miner: start propagating and consuming blob txs #28243

merged 7 commits into from
Oct 4, 2023

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Oct 3, 2023

This PR starts feeding blobpool transaction events into all other parts of Geth via the tx subscription mechanism. A few caveats:

  • Blob transactions fed into the event system will always be without sidecars. Feeding the blobs through everything would be very expensive. If something needs the blobs themselves, those should request it explicitly.
  • If Cancun is enabled, eth/67 is disabled since there's no way to tag the tx announcements with the blobs. Whilst this wouldn't necessarily be needed just now, it's IMO good practice.
  • The subscriptions were extended to allow subscribing to new transaction that either include or not reorged resurrections. This is good because things that are pulled back up from disk should already be known to everybody, so there's no point in reannouncing them.

@karalabe karalabe added this to the 1.13.3 milestone Oct 3, 2023
lightclient
lightclient reviewed Oct 3, 2023
View reviewed changes
core/txpool/blobpool/blobpool.go Outdated Show resolved Hide resolved
eth/handler.go Outdated Show resolved Hide resolved
MariusVanDerWijden
MariusVanDerWijden approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit a8a9c8e into ethereum:master Oct 4, 2023
1 check passed
hyunchel pushed a commit to hyunchel/go-ethereum that referenced this pull request Oct 6, 2023
@karalabe @hyunchel
core, eth, miner: start propagating and consuming blob txs (ethereum#…
87cc158 
…28243)

* core, eth, miner: start propagating and consuming blob txs

* eth/protocols/eth: disable eth/67 if Cancun is enabled

* core/txpool, eth, miner: pass gas limit infos in lazy tx for mienr filtering

* core/txpool, miner: add lazy resolver for pending txs too

* core, eth: fix review noticed bugs

* eth, miner: minor polishes in the mining and announcing logs

* core/expool: unsubscribe the event scope
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
@karalabe @tyler-smith
core, eth, miner: start propagating and consuming blob txs (ethereum#…
60085ec 
…28243)

* core, eth, miner: start propagating and consuming blob txs

* eth/protocols/eth: disable eth/67 if Cancun is enabled

* core/txpool, eth, miner: pass gas limit infos in lazy tx for mienr filtering

* core/txpool, miner: add lazy resolver for pending txs too

* core, eth: fix review noticed bugs

* eth, miner: minor polishes in the mining and announcing logs

* core/expool: unsubscribe the event scope
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023
@karalabe @tyler-smith
core, eth, miner: start propagating and consuming blob txs (ethereum#…
36f77b3 
…28243)

* core, eth, miner: start propagating and consuming blob txs

* eth/protocols/eth: disable eth/67 if Cancun is enabled

* core/txpool, eth, miner: pass gas limit infos in lazy tx for mienr filtering

* core/txpool, miner: add lazy resolver for pending txs too

* core, eth: fix review noticed bugs

* eth, miner: minor polishes in the mining and announcing logs

* core/expool: unsubscribe the event scope
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@karalabe @devopsbo3
core, eth, miner: start propagating and consuming blob txs (ethereum#…
723fd06 
…28243)

* core, eth, miner: start propagating and consuming blob txs

* eth/protocols/eth: disable eth/67 if Cancun is enabled

* core/txpool, eth, miner: pass gas limit infos in lazy tx for mienr filtering

* core/txpool, miner: add lazy resolver for pending txs too

* core, eth: fix review noticed bugs

* eth, miner: minor polishes in the mining and announcing logs

* core/expool: unsubscribe the event scope
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core, eth, miner: start propagating and consuming blob txs (e…
1af6099 
…thereum#28243)"

This reverts commit 723fd06.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "core, eth, miner: start propagating and consuming blob txs (e…
f7a4418 
…thereum#28243)"

This reverts commit 723fd06.
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Jan 16, 2024
@karalabe @tyler-smith
core, eth, miner: start propagating and consuming blob txs (ethereum#…
37df5b5 
…28243)

* core, eth, miner: start propagating and consuming blob txs

* eth/protocols/eth: disable eth/67 if Cancun is enabled

* core/txpool, eth, miner: pass gas limit infos in lazy tx for mienr filtering

* core/txpool, miner: add lazy resolver for pending txs too

* core, eth: fix review noticed bugs

* eth, miner: minor polishes in the mining and announcing logs

* core/expool: unsubscribe the event scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lightclient lightclient lightclient left review comments

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.3
Development

Successfully merging this pull request may close these issues.
3 participants
@karalabe @lightclient @MariusVanDerWijden