Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient: Fix eth_getBlockReceipts call when using block numbers or labels #28358

Merged
merged 2 commits into from
Oct 25, 2023
Merged

ethclient: Fix eth_getBlockReceipts call when using block numbers or labels #28358

merged 2 commits into from
Oct 25, 2023

Commits on Oct 17, 2023

  1. ethclient: Fix eth_getBlockReceipts call when using block numbers or … 

    …labels

The String() version of BlockNumberOrHash uses decimal for all block numbers, including negative ones used to indicate labels. Switch to using BlockNumber.String() which encodes it correctly for use in the JSON-RPC API.
    @ajsutton
    ajsutton committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    488f525 View commit details
    Browse the repository at this point in the history

  2. ethclient: Simplify new test to match typical style.

    @ajsutton
    ajsutton committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    dc81db0 View commit details
    Browse the repository at this point in the history