Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/txpool/legacypool: respect nolocals-setting #28435

Merged
merged 8 commits into from
Nov 20, 2023
Merged

core/txpool/legacypool: respect nolocals-setting #28435

merged 8 commits into from
Nov 20, 2023

Commits on Nov 14, 2023

  1. core/txpool/legacypool: Enforce MinTip in the legacypool for local tr… 

    …ansactions
    @jp-imx
    jp-imx committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bffa606 View commit details
    Browse the repository at this point in the history

  2. 28125: check config.NoLocals on legacypool's validateTxBasics

    @jp-imx
    jp-imx committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    d5848e3 View commit details
    Browse the repository at this point in the history

  3. Wrapped in pool.config.PrioritizeLocals() for readbility

    @jp-imx
    jp-imx committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    ee8097e View commit details
    Browse the repository at this point in the history

  4. Addressing PR feedback. Now setting local = false when NoLocals is set

    @jp-imx
    jp-imx committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    827f7e6 View commit details
    Browse the repository at this point in the history

  5. Revert "Addressing PR feedback. Now setting local = false when NoLoca… 

    …ls is set"

This reverts commit 75d4098bf2cff119ce424840e7786a1592170c52.

The local flag doesn't propagate to validation logic, only opts.MinTip
    @jp-imx
    jp-imx committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bad6717 View commit details
    Browse the repository at this point in the history

  6. Added missing checks to test

    @jp-imx
    jp-imx committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    01fa6d9 View commit details
    Browse the repository at this point in the history

  7. Moved local flag check to the top of Add function

    @jp-imx
    jp-imx committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5927f62 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. core/txpool/legacypool: extend test

    @MariusVanDerWijden
    MariusVanDerWijden committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0dc44d0 View commit details
    Browse the repository at this point in the history