Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient: simplify error handling in TransactionReceipt #28748

Merged
merged 7 commits into from
Jan 4, 2024
Merged

ethclient: simplify error handling in TransactionReceipt #28748

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4bff96
improve error handling
rosenk Dec 29, 2023
853b07a
Update ethclient/ethclient.go
holiman Dec 30, 2023
6bcb435
Merge branch 'ethereum:master' into patch-1
rosenk Dec 30, 2023
201e26c
fix white spaces
rosenk Dec 30, 2023
63cddaf
Merge branch 'ethereum:master' into patch-1
rosenk Jan 2, 2024
9c77216
Merge branch 'ethereum:master' into patch-1
rosenk Jan 4, 2024
0924ae5
Update ethclient.go
fjl Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ethclient/ethclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,8 @@ func (ec *Client) TransactionInBlock(ctx context.Context, blockHash common.Hash,
func (ec *Client) TransactionReceipt(ctx context.Context, txHash common.Hash) (*types.Receipt, error) {
var r *types.Receipt
err := ec.c.CallContext(ctx, &r, "eth_getTransactionReceipt", txHash)
if err == nil {
if r == nil {
return nil, ethereum.NotFound
}
if err == nil && r == nil {
return nil, ethereum.NotFound
}
return r, err
}
Expand Down
Loading