Makefile, build: move cross compilation into ci.go #2896
Merged
+57
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Mon Aug 8 10:44:06 UTC 2016 |
|
@karalabe, thanks for your PR! By analyzing the annotation information on this pull request, we identified @fjl and @Gustav-Simonsson to be potential reviewers |
karalabe
force-pushed
the
fix-xgo-crossbuilds
branch
from
87dea7c to
8c23f20
Compare
|
|
||
| // Execute the actual cross compilation | ||
| pkg := cmdline[len(cmdline)-1] | ||
| args := append(cmdline[:len(cmdline)-1], makeBuildFlags("")...) |
There was a problem hiding this comment.
Would be nice to have the commit hash in cross compiled binaries as well. I guess we can do that later if/when we import xgo rather than call it as a command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken
xgocross builders due to the CI reorgs done a while back.