Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereum, ethclient: add blob transaction fields in CallMsg #28989

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Feb 14, 2024

Add blob transaction fields in the eth client.

@mask-pp mask-pp marked this pull request as draft February 14, 2024 15:53
@fjl fjl changed the title feat(client): Let client enable call blob tx ethclient: add blob transaction fields Feb 14, 2024
@fjl
Copy link
Contributor

fjl commented Feb 14, 2024

Hi, could you please remove the contract backend changes from this PR and keep the ethclient and interfaces.go changes only? We do not want to make changes to the contract backend right now since it will be deprecated by #26782.

@mask-pp mask-pp marked this pull request as ready for review February 14, 2024 16:45
@mask-pp
Copy link
Contributor Author

mask-pp commented Feb 14, 2024

Hi, could you please remove the contract backend changes from this PR and keep the ethclient and interfaces.go changes only? We do not want to make changes to the contract backend right now since it will be deprecated by #26782.

@fjl Reverted, thanks :)

@fjl fjl changed the title ethclient: add blob transaction fields ethereum, ethclient: add blob transaction fields in CallMsg Feb 14, 2024
@fjl fjl merged commit 9d537f5 into ethereum:master Feb 15, 2024
2 of 3 checks passed
@fjl fjl added this to the 1.13.13 milestone Feb 15, 2024
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
0xmountaintop pushed a commit to scroll-tech/go-ethereum that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants