common/hexutil: use assembly hex encoder on amd64 #30075
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR vendors in the crux of https://github.com/tmthrgd/go-hex.
The reason the lib cannot be used as a dependency is because it redefines the error types from hex with a different message (whyy) and one of the errors is private, so it cannot be matched against.
I deleted most stuff and only left the main encoder and decoder in place, redirected the errors to use the stdlib hex errors, and I've replaced the "generic" encoder included in the lib with the stdlib one (faster).
If we get somewhere meaningful, we might consider upstreaming it via golang/go#68188, though I'm not seeing too big of an appreciation for it.