eth/catalyst: use setcanonical instead of sethead in simulated fork #30465
Conversation
|
Hmm looks like a test for the simulated backend fails with this |
|
In order to fix the failing test, I had to change the test semantics. In the old behaviour, it expected a dropped block to simply disappear, along with all txs. Now, however, we expect it to use the fork-events, where the tx pool actually picks up transactions that were dropped in a dropped head. I'm not 100% sure if the changed test is ok, or if we should replace/fix it some other way. cc @karalabe ? |
| @@ -228,15 +228,13 @@ func TestForkResendTx(t *testing.T) { | |||
| if err := sim.Fork(parent.Hash()); err != nil { | |||
| t.Errorf("forking: %v", err) | |||
| } | |||
|
|
|||
| // 5. | |||
| sim.Commit() | |||
| if err := client.SendTransaction(ctx, tx); err != nil { | |||
There was a problem hiding this comment.
It seems the 2nd SendTransaction can be omitted if the tx is expected to be picked up automatically?
Fixes #30448