Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trie/utils: remove useless SetZero for verkle #30472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

trie/utils: remove useless SetZero for verkle #30472

wants to merge 1 commit into from
+0 −6

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Sep 20, 2024 •
edited
Loading

The default value of fr.Element is already zero, you can see the evidence in go-verkle here:

  1. https://github.com/ethereum/go-verkle/blob/dffa7562dbe971a9776f43795d49177a18ecb5c8/tree.go#L273

  2. https://github.com/ethereum/go-verkle/blob/dffa7562dbe971a9776f43795d49177a18ecb5c8/tree.go#L294

It doesn't call SetZero for those already zeroed fr.Elements.

@zhiqiangxu zhiqiangxu changed the title remove useless SetZero trie/utils: remove useless SetZero for verkle Sep 20, 2024
gballet
gballet requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably fine, but I'm blocking this until I was able to check on a testnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gballet gballet gballet requested changes

@jwasinger jwasinger jwasinger approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangxu @gballet @jwasinger