Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/tracing: add GetTransientState method to StateDB interface for accessing transient state data #30531

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

kchojn
Copy link
Contributor

@kchojn kchojn commented Oct 1, 2024

The previous tracing implementation gave access to TransientState, in the current one is missing, so I extended the interface. I checked and no hooks collect it.

This gives the ability to analyze the transient state for custom tracers (e.g. mine).

@kchojn kchojn requested a review from s1na as a code owner October 1, 2024 08:34
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1na
Copy link
Contributor

s1na commented Oct 9, 2024

Is there anything else that we need to add? would appreciate if we do it in one PR.

@kchojn
Copy link
Contributor Author

kchojn commented Oct 9, 2024

I think not, I tested a lot of functionality and it seems to me that all the necessary things are there. Thanks

@s1na s1na merged commit 16bf471 into ethereum:master Oct 10, 2024
3 checks passed
holiman pushed a commit that referenced this pull request Nov 19, 2024
Allows live custom tracers to access contract transient storage through the StateDB interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants