crypto, tests/fuzzers: add gnark bn254 precompile methods for fuzzing #30585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Oct 12, 2024
kevaundray
commented
Oct 12, 2024
|
running |
|
running BenchmarkPrecompiledBn256Add after change with Option 3: |
|
running BenchmarkPrecompiledBn256Add after change with Option 2: |
|
running BenchmarkPrecompiledBn256Add after change with Option 1: |
|
running BenchmarkPrecompiledBn256ScalarMul before this change: after this change: |
|
running BenchmarkPrecompiledBn256Pairing before this change: after this change: Note: |
|
Could you also add it to the fuzzer already? |
Yep, I'll modify the fuzzer code
Alright, I'll delete the g1_aff code and go with
I'll open up an issue in Gnark to upstream this -- its not in gnark because its catering to a specific usecase that is expensive for every other usecase. |
MariusVanDerWijden
approved these changes
Oct 21, 2024
jwasinger
reviewed
Oct 21, 2024
holiman
reviewed
Oct 23, 2024
Comment on lines
+1
to
+6
| package bn256 | ||
|
|
||
| import ( | ||
| "math/big" | ||
|
|
||
| "github.com/consensys/gnark-crypto/ecc/bn254" |
There was a problem hiding this comment.
Me not being a cryptographer, bear with me... This is package bn256, but it operates on bn254 operands? Why the discrepancy?
There was a problem hiding this comment.
This was mainly poor historical naming: bn128/bn256/bn254 all refer to the same thing -- the discrepancy in numbers refer to different properties of the curve.
The 128 referred to the level of security, however it was found out that it did not have this level of security and then it was changed to bn256 or bn254 depending on who you ask
holiman
changed the title
holiman
changed the title
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
…#30585) Makes the gnark precompile methods more amenable to fuzzing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the gnark precompile methods so that they can be used as fuzzing and perhaps in the future replace the google variant; I noticed that the google variant looked quite similar to the cloudflare one.