build: reenable building arm64 concurrently #30626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of an experiment. Originally we used travis arm64 to build, and had to reduce build concurrency due to limited memory. Nowadays we don't cross build, only to docker, and on that we use amd64 builders. This PR is an attempt to speed up the docker image builders so it doesn't take 45 minutes.
Then again, it could happen that the CI env var isn't passed to docker at all. Oh well, I don't really see a reason to constrain ourselves. We can revert if something downstream borks.