eth/tracers/internal/tracertest: add missing Random to call context #30652
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namiloh
reviewed
Oct 22, 2024
|
btw I think the isMerge param in the and ChainConfig should add IsMerge() like func isShanghai |
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
…30652) Fixes a configuration issue in a test-helper, so that we can do call tracing-tests post-merge
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
…thereum#30652) Fixes a configuration issue in a test-helper, so that we can do call tracing-tests post-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a test locally, but the callTracer test always complains
invalid opcode: PUSH0if we want to test chain after the Merge, then the Random(aka prevRandao) should be not be nil
go-ethereum/core/vm/evm.go
Line 128 in a5fe735
go-ethereum/params/config.go
Lines 923 to 925 in a5fe735