ethclient: add RevertErrorData function and example #30669
Merged
+294
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| } | ||
| fmt.Println("message:", message) | ||
|
|
||
| // Output: |
There was a problem hiding this comment.
I think we should test for the message here, otherwise the test only tests that the revert unpacking doesn't error
There was a problem hiding this comment.
Go checks the output of example functions. The comment here declares the expected output. If there is a mismatch, the example fails during go test.
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
This is done to make the RevertErrorData example code look better.
holiman
pushed a commit
that referenced
this pull request
Nov 19, 2024
Here I'm adding a new helper function that extracts the revert reason of a contract call. Unfortunately, this aspect of the API is underspecified. See these spec issues for more detail: - ethereum/execution-apis#232 - ethereum/execution-apis#463 - ethereum/execution-apis#523 The function added here only works with Geth-like servers that return error code `3`. We will not be able to support all possible servers. However, if there is a specific server implementation that makes it possible to extract the same info, we could add it in the same function as well. --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I'm adding a new helper function that extracts the revert reason of a contract call.
Unfortunately, this aspect of the API is underspecified. See these spec issues for more detail:
eth_callunderspecified return error message execution-apis#463eth_sendTransaction,eth_sendRawTransactionandeth_estimateGasexecution-apis#523The function added here only works with Geth-like servers that return error code
3. We will not be able to support all possible servers. However, if there is a specific server implementation that makes it possible to extract the same info, we could add it in the same function as well.