core/state, triedb/database: refactor state reader #30712
Merged
+50
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
approved these changes
Nov 4, 2024
| } | ||
|
|
||
| // StateDatabase warps the methods of a backing state store. | ||
| type StateDatabase interface { |
There was a problem hiding this comment.
Wait this is currently unused, right?
Is this going to be used in a follow-up pr?
Also the StateReader interface is not really needed since we only use it once, are we going to use it more in the future?
There was a problem hiding this comment.
Yeah, StateReader interface will be used in the future. This interface will be implemented by both triedb.StateReader and state.Snapshot.
holiman
reviewed
Nov 4, 2024
holiman
added a commit
that referenced
this pull request
Nov 19, 2024
Co-authored-by: Martin HS <martin@swende.se>
zfy0701
pushed a commit
to sentioxyz/go-ethereum
that referenced
this pull request
Dec 3, 2024
Co-authored-by: Martin HS <martin@swende.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.