Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils: change blssync.JWTSecretFlag to DirectoryFlag #30729

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

MariusVanDerWijden
Copy link
Member

closes #30304

We already use DirectoryFlag for authrpc.jwtsecret which expands the tilde, so this should work out of the box

@namiloh
Copy link

namiloh commented Nov 5, 2024

A directory flag does not accept an explicit file, iirc from when I looked at this. Please provide commandline example showing that it indeed works as expected.

@MariusVanDerWijden
Copy link
Member Author

go run ./cmd/blsync --sepolia --beacon.api=https://xxx.io --beacon.checkpoint=$(curl -X 'GET' -
H 'accept: application/json' 'https://xxx.io/eth/v1/beacon/headers/finalized' | jq -r ".data.root") --blsync.engine.api=http://localhost:8551 --blsync.jwtsecr
et=~/.ethereum/sepolia/geth/jwtsecret
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (7) Failed to connect to xxx.io port 443 after 912 ms: Could not connect to server
INFO [11-05|10:59:24.464] Loaded JWT secret file                   path=/home/matematik/.ethereum/sepolia/geth/jwtsecret crc32=0x865194cd
WARN [11-05|10:59:25.119] Beacon API request failed                type=sync.ReqCheckpointData reqid=1 err="Get \"https://xxx.io/eth/v1/beacon/light_client/bootstrap/0x456e85f5608afab3465a0580bff8572255f6d97af0c5f939e3f7536b5edb2d3f\": dial tcp 47.240.5.85:443: connect: connection refused"
WARN [11-05|10:59:25.129] Head event stream error                  err="error creating event subscription: Get \"https://xxx.io/eth/v1/events?topics=head&topics=light_client_finality_update&topics=light_client_optimistic_update\": dial tcp 47.240.5.85:443: connect: connection refused"
^Csignal: interrupt

(host is not responding, but it correctly resolves the secret)

@namiloh
Copy link

namiloh commented Nov 5, 2024 via email

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman merged commit 9c08631 into ethereum:master Nov 6, 2024
3 checks passed
@holiman holiman added this to the 1.14.12 milestone Nov 6, 2024
holiman pushed a commit that referenced this pull request Nov 19, 2024
closes #30304

We already use `DirectoryFlag` for `authrpc.jwtsecret` which expands the
tilde, so this should work out of the box
zfy0701 pushed a commit to sentioxyz/go-ethereum that referenced this pull request Dec 3, 2024
)

closes ethereum#30304

We already use `DirectoryFlag` for `authrpc.jwtsecret` which expands the
tilde, so this should work out of the box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blsync does not expand tilde for home
3 participants