Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/abi: unpack error into interface #30738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

accounts/abi: unpack error into interface #30738

wants to merge 2 commits into from

Conversation

darrenvechain
Copy link

@darrenvechain darrenvechain commented Nov 6, 2024 •
edited
Loading

This PR adds the error fragments to func (abi ABI) getArguments which allows typed decoding of errors

@darrenvechain darrenvechain changed the title abi: unpack error into interface accounts/abi: unpack error into interface Nov 6, 2024
rjl493456442
rjl493456442 approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

@MariusVanDerWijden MariusVanDerWijden Awaiting requested review from MariusVanDerWijden MariusVanDerWijden is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darrenvechain @rjl493456442