Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trie: replace custom logic with bytes.HasPrefix #30771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

trie: replace custom logic with bytes.HasPrefix #30771

wants to merge 1 commit into from

Conversation

j2gg0s
Copy link

@j2gg0s j2gg0s commented Nov 20, 2024

in trie

  • Replace custom logic with bytes.HasPrefix
  • Remove unnecessary code in GetNode

rjl493456442
rjl493456442 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

I think it improves the readability a lot and lean to include this change.
But I need @holiman and @fjl 's opinion as the changes touch very core part.

holiman
holiman approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.14.13 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.13
Development

Successfully merging this pull request may close these issues.
3 participants
@j2gg0s @holiman @rjl493456442