Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #30779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix some typos #30779

wants to merge 1 commit into from
+4 −4

Conversation

wangjingcun
Copy link

Since err != nil has been judged before, nil is returned directly here, which is more obvious, readable and less error-prone.

lightclient
lightclient approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

holiman
holiman requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any point in modifying the old accounts-files.

The typos might be worth fixing though

@wangjingcun
Copy link
Author

I don't see any point in modifying the old accounts-files.

The typos might be worth fixing though

Should I roll back the relevant modifications in the accounts directory?

@lightclient
Copy link
Member

@wangjingcun yes please, we will just accept the typos.

@wangjingcun
Fix some typos
497109a 
Signed-off-by: wangjingcun <wangjingcun@aliyun.com>
@wangjingcun
Copy link
Author

@wangjingcun yes please, we will just accept the typos.

Reverted. Please review again.

@wangjingcun wangjingcun changed the title Use a more direct and less error-prone return value Fix some typos Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman requested changes

@lightclient lightclient lightclient approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangjingcun @lightclient @holiman