Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/gasprice: ensure cache purging goroutine terminates with subscription #31025

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

jwasinger
Copy link
Contributor

No description provided.

…n't hang after dependent subscription is closed
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl changed the title eth/gasprice: ensure goroutine that that purges cache upon reorg doesn't hang after dependent subscription is closed eth/gasprice: ensure cache purging goroutine terminates with subscription Jan 14, 2025
@fjl fjl added this to the 1.14.13 milestone Jan 14, 2025
@fjl fjl merged commit 8dfad57 into ethereum:master Jan 14, 2025
2 of 3 checks passed
s1na pushed a commit to s1na/go-ethereum that referenced this pull request Jan 15, 2025
@fjl fjl modified the milestones: 1.14.13, 1.15.0 Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants