all: define constructor for BlobSidecar #32213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
MariusVanDerWijden,
fjl,
jwasinger,
lightclient and
s1na
as code owners
rjl493456442
commented
Jul 15, 2025
| if err != nil { | ||
| // TODO @rjl @marius we should return an error | ||
| log.Info("Failed to get cell proof", "err", err) | ||
| return nil, nil |
Member
Author
There was a problem hiding this comment.
I am not sure it's the correct way to return the error in engine API. @lightclient @MariusVanDerWijden please check it out
Member
There was a problem hiding this comment.
InvalidParams is probably the most correct in this case
MariusVanDerWijden
previously approved these changes
Jul 15, 2025
Member
MariusVanDerWijden
left a comment
MariusVanDerWijden
left a comment
There was a problem hiding this comment.
LGTM, much cleaner than before
miner/worker.go
Outdated
| if err := sidecar.ToV1(); err != nil { | ||
| txs.Shift() | ||
| txs.Pop() | ||
| log.Info("Failed to recompute cell proofs", "hash", ltx.Hash, "err", err) |
Member
There was a problem hiding this comment.
This should probably be a warn or an error, it means that we have transactions in our blobpool that we can't turn into V1 transactions, thus someone could fill up the pool with invalid/non-mineable transaction
MariusVanDerWijden
approved these changes
Jul 15, 2025
howjmay
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Aug 27, 2025
The main purpose of this change is to enforce the version setting when constructing the blobSidecar, avoiding creating sidecar with wrong/default version tag.
gballet
pushed a commit
to gballet/go-ethereum
that referenced
this pull request
Sep 11, 2025
The main purpose of this change is to enforce the version setting when constructing the blobSidecar, avoiding creating sidecar with wrong/default version tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this change is to enforce the version setting when constructing
the blobSidecar, avoiding creating sidecar with wrong/default version tag.