Skip to content

core: replace the empty fmt.Errorf with errors.New #32274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

core: replace the empty fmt.Errorf with errors.New #32274

merged 1 commit into from
Jul 28, 2025

Conversation

nthumann
Copy link
Contributor

The errors.new function does not require string formatting, so its performance is better than that of fmt.Errorf.

@nthumann nthumann requested a review from rjl493456442 as a code owner July 25, 2025 07:22
@rjl493456442 rjl493456442 added this to the 1.16.2 milestone Jul 28, 2025
@rjl493456442 rjl493456442 merged commit 29eebb5 into ethereum:master Jul 28, 2025
4 of 5 checks passed
@ericxtheodore ericxtheodore mentioned this pull request Jul 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@tim2346 tim2346 tim2346 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@nthumann @rjl493456442 @tim2346