all: check error returned from rlp.Encode()
#33035
Closed
+26
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wit765
requested review from
fjl,
gballet,
rjl493456442 and
zsfelfoldi
as code owners
wit765
changed the title
rlp.Encoderlp.Encode
wit765
force-pushed
the
rlp-up
branch
2 times, most recently
from
2be0331 to
7be12f8
Compare
wit765
changed the title
rlp.Encoderlp.Encode()
|
|
||
| h := sha3.NewLegacyKeccak256() | ||
| rlp.Encode(h, cpy.AppendElements(nil)) | ||
| if err := rlp.Encode(h, cpy.AppendElements(nil)); err != nil { |
There was a problem hiding this comment.
The RLP encoding will always succeed in this case
|
It's acceptable to omit some error checks in the test, or we pretty sure the RLP encoding will succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks error which is returned by the function
rlp.Encode().