core/vm: implement opcode REVERT - eip#140 #3627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@obscuren, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Arachnid, @fjl and @Gustav-Simonsson to be potential reviewers. |
obscuren
force-pushed
the
eip140-revert
branch
from
c5aed81
to
20aa1b0
Compare
|
You've implemented the first suggestion, which afaict has been superseeded by https://github.com/axic/EIPs/blob/20fdb8ccd069f5a70ebe8566c81d6f35086a6493/EIPS/eip-draft_revert_opcode.md . The big difference is that |
|
@holiman it hasn't been accepted yet. It was another proposal that was discussed. |
|
PR has been updated according to the new specification |
|
Just to be clear, which specification is being followed? |
|
@holiman the one you linked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/EIPs#140