Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: drop eth_compile #3740

Merged
merged 1 commit into from
Mar 16, 2017
Merged

internal/ethapi: drop eth_compile #3740

merged 1 commit into from
Mar 16, 2017

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Mar 3, 2017

@mention-bot
Copy link

@karalabe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zsfelfoldi, @fjl and @obscuren to be potential reviewers.

@karalabe karalabe requested review from fjl and obscuren March 3, 2017 09:51
@karalabe karalabe added this to the 1.6.0 milestone Mar 3, 2017
@karalabe karalabe added the review label Mar 3, 2017
@bas-vk
Copy link
Member

bas-vk commented Mar 15, 2017

There is also the --solc commandline flag and admin_setSolc that can be removed?
Afaik these are only used by the rpc methods.

@fjl fjl merged commit 61ede86 into ethereum:master Mar 16, 2017
This was referenced Mar 16, 2017
Closed
Closed
@bas-vk bas-vk mentioned this pull request Mar 30, 2017
Closed
@Ban44n Ban44n mentioned this pull request Nov 28, 2017
Closed
@brandoncurtis brandoncurtis mentioned this pull request Apr 22, 2018
Closed
1 task
@colltoaction colltoaction mentioned this pull request Oct 17, 2019
Closed
@aeharvlee aeharvlee mentioned this pull request Dec 14, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@obscuren obscuren Awaiting requested review from obscuren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@karalabe @mention-bot @bas-vk @fjl