RPC Hexify #609
Merged
RPC Hexify #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tgerring
commented
Mar 31, 2015
tgerring
commented
- Define new hexnum and hexdata types to convey formatting information (updated spec)
- Compact constructor and marshal steps (reduces codes)
- Fix RPC: "eth_getTransactionByBlockNumberAndIndex" refused connection #607
- Fix RPC: "eth_getTransactionByHash" returns a transaction with empty blockHash and blockNumber #608
- Updated eth_call arguments
- Fix or remove response tests (low priority)
Requirements for calls differ from transactions
Benefits from automatic output formatting differences between quantities and data
Now formats based on underlying hexdata or hexnum type. Fields directly with respective constructors that cover from native types
Improving this in the future will allow for cleaning up a bit of legacy code.
| func newHexData(input interface{}) *hexdata { | ||
| d := new(hexdata) | ||
|
|
||
| switch input.(type) { |
There was a problem hiding this comment.
Change this to
switch input := input.(type) {
case common.Hash:
d.data = input.Bytes()
}No need to do the extra type assertions
Actually verifies output as by regex
ngtuna
added a commit
to ngtuna/tomochain
that referenced
this pull request
Aug 7, 2019
…-orders-after-waking-up Sync orders after sdkNodes wake up
ngtuna
added a commit
to ngtuna/tomochain
that referenced
this pull request
Aug 7, 2019
ngtuna
added a commit
to ngtuna/tomochain
that referenced
this pull request
Aug 8, 2019
Cancel order: follow up ethereum#609
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.