Frontier/513 #616
Merged
Frontier/513 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,8 +128,8 @@ func cTopics(t [][]string) [][]common.Hash { | |||
| return topics | |||
| } | |||
|
|
|||
| func (self *XEth) DefaultGas() *big.Int { return defaultGas } | |||
| func (self *XEth) DefaultGasPrice() *big.Int { return defaultGasPrice } | |||
| func (self *XEth) DefaultGas() *big.Int { return big.NewInt(defaultGas.Int64()) } | |||
There was a problem hiding this comment.
Change to
return new(big.Int).Set(defaultGas)
- Potential risk for overflow once we've added price discovery
- Big => int => big will do the following
b = COMP_TO_BYTES(big)
i = BIN_TO_INT(b)
b = INT_TO_BIN(i)
big = BYTES_TO_COMP(b)
where as Set will do a copy
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
This reverts commit 58a4453.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pointer to the default gas value is assigned to a member field of a message which is passed to the evm for execution. In the evm the used gas is subtracted which causes the default gas value to decrease on each call when no gas value is supplied. After enough calls the user runs "out of gas".