Issue #654 #656
Closed
Issue #654 #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: xeth/xeth.go
|
What is this? There are no changed files in this PR |
|
Don't know what happened, but seems the commits were somehow integrated. Tested on develop HEAD and got same 215 passing / 2 failing, so I'm closing this and will re-open with any next fixes accordingly. |
jpeletier
pushed a commit
to epiclabs-io/go-ethereum
that referenced
this pull request
Jun 11, 2018
* remove unused struct - please correct me if this should stay. * generic use of self, add comments to exported functions * swarm/api/api.go:49:2: var apiGetHttp300 should be apiGetHTTP300 * forgot a reference * swarm/api/api.go:414:10: if block ends with a return statement, so drop this else and outdent its block * swarm/api/api.go:219:6: func NewApi should be NewAPI * swarm/api/api.go:212:6: type Api should be API Don't hate the messenger 😵 I'm just doing what golint tells me to do 🙃 * swarm/api/http/server.go:529:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple) * swarm/api/api.go:212:6: type Api should be API * swarm/api/api.go:721:1: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" * swarm/api/api.go:223:6: func NewApi should be NewAPI * add requisite comments * remove unused struct - please correct me if this should stay. * swarm/api/api.go:50:2: var apiGetHttp300 should be apiGetHTTP300 * swarm/api/api.go:229:1: comment on exported function NewAPI should be of the form "NewAPI ..." * swarm/api/api.go:234:1: comment on exported method API.Retrieve should be of the form "Retrieve ..." * swarm/api/api.go:74:6: exported type NoResolverError should have comment or be unexported * swarm/api/api.go:415:10: if block ends with a return statement, so drop this else and outdent its block * swarm/api/http/server.go:530:2:warning: should merge variable declaration with assignment on next line (S1021) (gosimple) * implement suggestions from @zelig & nolash * refixing issues that disappeared during the merge. * missed a few points of feedback that need included * implement suggestions * remove all my '-' I got a little dash happy that day
tony-ricciardi
pushed a commit
to tony-ricciardi/go-ethereum
that referenced
this pull request
Jan 20, 2022
s1na
pushed a commit
to s1na/go-ethereum
that referenced
this pull request
Dec 2, 2024
Co-authored-by: 賴怡誠 <laiyicheng@makotos-MBP.lan>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654 and adds extra test coverage