-
Notifications
You must be signed in to change notification settings - Fork 20.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admin.StopRPC added to console #734
Conversation
As general feedback, there is no need to store pointers to channels. Just store the channel directly. |
What exactly is so bad about just closing the listener and letting those connections time out? Given that |
Not closing connections can cause unexpected behaviour from the users point of view. If you let these connections remain open users will be able to execute transactions as long as the connection is kept alive which is not really what you would expected after a stopRPC. Closing idle connection will (hopefully) be supported in go 1.5. What I suggest, support closing idle connections for now and when golang/go/issues/4674 makes it to go 1.5 and most of our users are using go 1.5 replace this code with the code from the package. |
Just had a quick chat with @obscuren, we use the PR as is and when the CloseIdeConnections is implemented in the net package we remove this code. I will make add a comment that this code should be removed in the future. |
|
this can merge if green |
admin.StopRPC added to console
Make txArriveTimeout Configurable w/ CLI Flag
Adds support for stopping the rpc service in the console, this closes #729.
Note, it doesn't do a graceful shutdown. This could be added but will stall the console while waiting for idle connections to timeout.