Add block hash saving for non canon blocks #857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 5, 2015 03:10
* Ensure block hash is stored with the block number as key even if a block is non-canonical (not a new tip of the chain), this is required by the new chain forking code in the edge cases tested by BlockTests/bcUncleTest.json * Rename and split up related DB / cache storage functions to make them easier to read. * Move if statement's simple statement to it's own line to get distinct stacktrace line number in case we get future bugs here.
| @@ -537,7 +517,7 @@ func (self *ChainManager) InsertChain(chain types.Blocks) (int, error) { | |||
| } | |||
|
|
|||
| block.Td = new(big.Int) | |||
| // Do not penelise on future block. We'll need a block queue eventually that will queue | |||
| // Do not penalize on future block. We'll need a block queue eventually that will queue | |||
There was a problem hiding this comment.
Please correct properly. Do not favour American English over correct English ;-) (i.e. penalise)
|
Yes, please wait with this one and check this fix first: #865 It avoids this scenario resulting in a panic and instead rejects the block. However the logic here still needs to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a block is non-canonical (not a new tip of the chain), this is
required by the new chain forking code in the edge cases tested
by BlockTests/bcUncleTest.json
them easier to read.
distinct stacktrace line number in case we get future bugs here.