Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix endianness issues in commitment calculations #185

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

gballet
Copy link
Member

@gballet gballet commented Feb 3, 2022

The endianness in commitments was wrong, this PR fixes it.

@gballet gballet added the bug Something isn't working label Feb 3, 2022
@gballet
Copy link
Member Author

gballet commented Feb 3, 2022

failing tests: looks like the endianness problem is also present in the proof, which is to be expected looking at the multipoint part.

ipa.go Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #185 (7d8046c) into master (150c713) will decrease coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   88.64%   88.06%   -0.58%     
==========================================
  Files           9        9              
  Lines         916      905      -11     
==========================================
- Hits          812      797      -15     
- Misses         79       82       +3     
- Partials       25       26       +1     
Impacted Files Coverage Δ
proof_ipa.go 89.18% <ø> (-1.22%) ⬇️
ipa.go 100.00% <100.00%> (ø)
stateless.go 83.57% <100.00%> (ø)
tree.go 90.68% <100.00%> (-0.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150c713...7d8046c. Read the comment docs.

@gballet gballet merged commit 2997a4a into master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants