-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print OpCode on partial exec failure #525
Conversation
src/EVM.hs
Outdated
@@ -230,6 +230,17 @@ isCreation = \case | |||
next :: (?op :: Word8) => EVM t s () | |||
next = modifying (#state % #pc) (+ (opSize ?op)) | |||
|
|||
getOpName :: forall (t :: VMType) s . FrameState t s -> [Char] | |||
getOpName state = intToOpName $ fromEnum $ (?op) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getOpName state = intToOpName $ fromEnum $ (?op) | |
getOpName state = intToOpName $ fromEnum (?op) |
I also don't understand why do you call it ?op
.
From what I read question mark at the beginning is used for implicit parameters, but that is not the case here, no?
Why not call it just op
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Let me try to fix...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you re-review? I cleaned up everything :)
b66cf46
to
63e0d0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Before:
Now:
Checklist