Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorry, I messed up the partial warning PR, this is a fix for that #547

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

msooseth
Copy link
Collaborator

Description

While it was being merged I messed it up. I'm sorry. This should be better now. No code duplication.

@blishko

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

Copy link
Collaborator

@blishko blishko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened there.
I thought you had getOptW8 already in the previous PR.

@msooseth
Copy link
Collaborator Author

Yes, it's weird. I'm sorry. No idea.

@blishko
Copy link
Collaborator

blishko commented Aug 29, 2024

I think this code is already in main, no?
Can you rebase it?

@msooseth msooseth merged commit 996ba8e into main Aug 29, 2024
9 checks passed
@msooseth msooseth deleted the fix-partial-warning branch August 29, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants