[DRAFT] Cheatcodes as per new std-forge library #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
implement_new_cheatcodes
branch
2 times, most recently
from
e78213a
to
c0cca47
Compare
msooseth
changed the title
msooseth
changed the title
msooseth
force-pushed
the
implement_new_cheatcodes
branch
7 times, most recently
from
fd7745f
to
527025f
Compare
msooseth
force-pushed
the
implement_new_cheatcodes
branch
from
527025f
to
a16d3c0
Compare
msooseth
commented
Oct 29, 2024
Comment on lines
-290
to
-297
| checkSymFailures :: VMOps t => UnitTestOptions RealWorld -> Stepper t RealWorld (VM t RealWorld) | ||
| checkSymFailures UnitTestOptions { .. } = do | ||
| -- Ask whether any assertions failed | ||
| Stepper.evm $ do | ||
| popTrace | ||
| abiCall testParams (Left ("failed()", emptyAbi)) | ||
| Stepper.runFully | ||
|
|
There was a problem hiding this comment.
This is not used anywhere, so I'm removing it
msooseth
force-pushed
the
implement_new_cheatcodes
branch
from
6d87659
to
0905738
Compare
d-xo
reviewed
Oct 31, 2024
| ") parameter decoding failed. Error: " <> show abivals | ||
| revertErr a b comp = frameRevert $ "assertion failed: " <> | ||
| BS8.pack (show a) <> " " <> comp <> " " <> BS8.pack (show b) | ||
| assertEq abitype sig input = do |
There was a problem hiding this comment.
I'm not super bothered by the duplication but if you wanted to cut some lines you could probably merge the implementations into one function that is parametrised on the comparison function and string used in the revert error?
src/EVM.hs
Outdated
| revertContracts | ||
| revertSubstate | ||
| assign (#state % #returndata) mempty | ||
| assign (#state % #returndata) (ConcreteBuf (BS8.pack $ show e)) |
There was a problem hiding this comment.
why do we need to do this for non reverting errors?
| @@ -224,6 +227,12 @@ symRun opts@UnitTestOptions{..} vm (Sig testName types) = do | |||
| -- check postconditions against vm | |||
| (e, results) <- verify solvers (makeVeriOpts opts) (symbolify vm') (Just postcondition) | |||
| let allReverts = not . (any Expr.isSuccess) . flattenExpr $ e | |||
| let fails = filter (Expr.isFailure) $ flattenExpr e | |||
| unless (null fails) $ liftIO $ do | |||
| putStrLn $ " \x1b[33mWARNING\x1b[0m: hevm was only able to partially explore the test " <> Text.unpack testName <> " due to: "; | |||
There was a problem hiding this comment.
Are failures the same as partial executions?
msooseth
force-pushed
the
implement_new_cheatcodes
branch
from
2cee6f1
to
48215cc
Compare
msooseth
force-pushed
the
implement_new_cheatcodes
branch
from
48215cc
to
b00abc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The way forge-std is doing things has changed. It no longer sets a value in ds-test, but instead
Revert-s with a specific message. So we have to match:Instead of the current:
Implementation
Emilio has changed things around already in
EVM.hsto have a separate frame, which allows this to be coded in a relatively compact way. I have now added a number of required (but not all) cheatcodes.Future work
I haven't added:
assertEq(T[], T[])type assertsassertNotEq(T[], T[])type assertsassertXXDecimalI need to cut the cheatcodes into a separate file. I'll do these in the next PR, this was it's a bit easier to review this PR.
Checklist