-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run rpc-compat on the latest clients #119
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 350.0 DAI (350.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 11 months, 3 weeks from now.
Learn more on the Gitcoin Issue Details page. |
@cryptomental You've been approved! Excited to see what you do here, as always 🙂 |
@cryptomental Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Day 1 - after initial reading I checked out Hive and I am looking around the codebase. Also #118 looks quite interesting as it gives a hint that the test environment is spin up with Vagrant and Ubuntu base image, therefore Ubuntu will be a base for me. I hope to open a WIP PR this week. I will update my progress on a daily basis. |
Yesterday, workspace checkout, docker image built and I was comparing branches mentioned in #190, today evening I have more time and will try to run the latest rpc compat tests. |
In the meantime since the last official run in 2017, cpp-ethereum was renamed to aleth, pyethapp was deprecated and ethereumj was added. I generated a new table and updated all results, including client logs and changes needed in App.js in my eth-compat-table fork: https://github.com/cryptomental/eth-compat-table I pushed everything in a single commit to: cryptomental/eth-compat-table@3f2e81b Perhaps at some point it would be beneficial to try to automate everything so that the table would be automatically created on CI and pushed but this is a different story. Just for the record I stored how I started the hive container and cached ethash DAG (go-ethereum circleci config helped me a lot).
Caching ethhash DAG and images is not needed, but speeds up next container starts. To generate eth-compat data, in the last command above I changed the entrypoint from hive.sh to sh, to start the interactive session and executed hive in --docker-noshell mode inside the container:
After the test completed I copied data from the container to eth-compat-table and renamed where necessary. I learnt a lot again. |
@vs77bb I submitted the bounty via GitCoin, the transaction went through https://etherscan.io/tx/0x38e260950f8da1159068f5c03bde507807eafdda08ac7c51ed528c5e3d4a0459 but strangely it was not recorded. I'll ping you via Slack with links. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 350.0 DAI (350.0 USD @ $1.0/DAI) has been submitted by: @vs77bb please take a look at the submitted work:
|
nice work! |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 350.0 DAI (350.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @cryptomental.
|
@cryptomental i've sent you a gitter message! |
All ok! :) |
rpc-compat is now maintained again, closing this issue. |
rpc-compat is a Hive script for testing client compatibility against an RPC test suite. It lives here but hasn't been tried in quite some time: https://github.com/karalabe/hive/tree/master/simulators/ethereum/rpc-compat
It would be nice to dust it off and run it again against the latest clients. Once run again, this RPC compatibility table can be updated (this table is very old, as you can see on the page these results are from 2017-02-24: http://cdetrio.github.io/eth-compat-table).
The documentation on how to run Hive and generate this table is not great, but there are some notes scattered in various places:
The text was updated successfully, but these errors were encountered: