Parity config update #123
Merged
Parity config update #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheme
reviewed
Sep 10, 2018
| @@ -4,7 +4,9 @@ | |||
| "Ethash": { | |||
| "params": { | |||
| "minimumDifficulty": "0x020000", | |||
| "blockReward": "0x4563918244F40000", | |||
| "blockReward": { | |||
| "0": "0x4563918244F40000", | |||
There was a problem hiding this comment.
Fixed, pushed directly into master
cheme
reviewed
Sep 10, 2018
| chainconfig=`echo $chainconfig | jq "setpath([\"engine\", \"Ethash\", \"params\", \"eip649Transition\"]; \"0x$HIVE_FORK_BYZANTIUM\")"` | ||
| # Set blockreward to 3M for byzantium | ||
| chainconfig=`echo $chainconfig | jq "setpath([\"engine\", \"Ethash\", \"params\", \"blockReward\",\"0x$HIVE_FORK_BYZANTIUM\"]; \"0x29A2241AF62C0000\")"` | ||
| # difficulty calculation -- aka bomb delay |
There was a problem hiding this comment.
For the bomb delay we also need to define additional variables :
chainconfig=`echo $chainconfig | jq "setpath([\"engine\", \"Ethash\", \"params\", \"difficultyBombDelays\",\"0x$HIVE_FORK_BYZANTIUM\"]; \"3000000\")"`
chainconfig=`echo $chainconfig | jq "setpath([\"engine\", \"Ethash\", \"params\", \"difficultyBombDelays\",\"0x$HIVE_FORK_CONSTANTINOPLE\"]; \"5000000\")"`
There was a problem hiding this comment.
I'm not sure that'll make a difference -- on hive there are only a couple of blocks, so whether the bomb is delayed to 3M or 5M shouldn't matter. Hive can't really be used to test the bomb delay, I think
There was a problem hiding this comment.
Also added an empty difficultyBombDelays struct to chain.json
There was a problem hiding this comment.
Hello, I made a small (big) mistake, our 'difficultyBombDelays' is additive so the right code should be
chainconfig=`echo $chainconfig | jq "setpath([\"engine\", \"Ethash\", \"params\", \"difficultyBombDelays\",\"0x$HIVE_FORK_BYZANTIUM\"]; \"3000000\")"`
chainconfig=`echo $chainconfig | jq "setpath([\"engine\", \"Ethash\", \"params\", "difficultyBombDelays\",\"0x$HIVE_FORK_CONSTANTINOPLE\"]; \"2000000\")"`
to have 5M total delay at constantinople.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle openethereum/parity-ethereum#9480: