internal/libhive: client definitions, metadata file loading, client-roles #443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Eth1 simulators should update like:
suite.Add(hivesim.ClientTestSpec{ + Role: "eth1', Run: runDiscoveryTest, Parameters: hivesim.Params{ "HIVE_LOGLEVEL": "5", }, })
To ensure the test only ever runs against the intended kind of client. If the test runner does not provide eth2 client names by accident, the old behavior still works.
Next, we can make other tests that consume "beacon", "validator", "shard-node", etc. roles.
For an Eth2 testnet, or Eth1-Eth2 merge test, multiple roles may be involved. The CLI does not change, just give it a list of involved clients. The simulator can e.g. find the first beacon node, first validator, first shard-node to run a simple testnet. Or parametrize by role, to try different combinations (e.g. for Eth2 validator <> beacon API tests, and beacon <> eth1 RPC tests).
TODO:
hive.yaml
in clients.