rpc-compat: add special test for debug_getBadBlocks
#630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm closing this because the p2p protocol no longer allows injecting block announcements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
debug_getBadBlocksrelies on the client seeing a bad block over p2p, I've added support in geth to send arbitrary new block announcements and have sealed a "bad" block in the execution-apis repo, along side the normalchain.rlp.This PR takes the provided bad block and sends it over the wire to the client. The client should then reject the block as invalid and record it somewhere to later be retrieved by
debug_getBadBlocks.