Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md, docs: fix typos in documentation #683

Merged
merged 3 commits into from
Jan 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ for validating Ethereum client implementations.
- go-ethereum:
- Genesis chain config couldn't handle present but empty settings: [#2790](https://github.com/ethereum/go-ethereum/pull/2790)
- Data race between remote block import and local block mining: [#2793](https://github.com/ethereum/go-ethereum/pull/2793)
- Downloader didn't penalize incompatible forks hashly enough: [#2801](https://github.com/ethereum/go-ethereum/pull/2801)
- Downloader didn't penalize incompatible forks harshly enough: [#2801](https://github.com/ethereum/go-ethereum/pull/2801)
- Nethermind:
- Bug in p2p whith bonding nodes algorithm found by Hive: [#1894](https://github.com/NethermindEth/nethermind/pull/1894)
- Bug in p2p with bonding nodes algorithm found by Hive: [#1894](https://github.com/NethermindEth/nethermind/pull/1894)
- Difference in return value for 'r' parameter in getTransactionByHash: [#2372](https://github.com/NethermindEth/nethermind/issues/2372)
- CREATE/CREATE2 behavior when account already has max nonce [#3698](https://github.com/NethermindEth/nethermind/pull/3698)
- Blake2 performance issue with non-vectorized code [#3837](https://github.com/NethermindEth/nethermind/pull/3837)
Expand All @@ -36,7 +36,7 @@ We follow the [Collective Code Construction Contract (C4)][c4], code contributio
as expanded and explained in [The ZeroMQ Process][zmq-process]. The core idea being that
any patch that successfully solves an issue (bug/feature) and doesn't break any existing
code/contracts must be optimistically merged by maintainers. Followup patches may be used
to for additional polishes – and patches may even be outright reverted if they turn out to
for additional polishes – and patches may even be outright reverted if they turn out to
have a negative impact – but no change must be rejected based on personal values.

### License
Expand Down
4 changes: 2 additions & 2 deletions docs/clients.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
This page explains how client containers work in Hive.

Clients are docker images which can be instantiated by a simulation. A client definition
consist of a Dockerfile and associated resources. Client definitions live in
consists of a Dockerfile and associated resources. Client definitions live in
subdirectories of `clients/` in the hive repository.

When hive runs a simulation, it first builds all client docker images using their
Expand Down Expand Up @@ -108,7 +108,7 @@ URL of the running instance.
### Environment

Clients must support the following environment variables. The client's entry point script
may map these to command line flags or use them generate a config file, for example.
may map these to command line flags or use them to generate a config file, for example.

| Variable   | Value   |     |
|----------------------------|---------------|------------------------------------------------|
Expand Down
2 changes: 1 addition & 1 deletion docs/simulators.md
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ Response:

{"id": "<container-id>", "ip": "172.1.2.4"}

#### Geting client information
#### Getting client information

GET /testsuite/{suite}/test/{test}/node/{container}

Expand Down