simulators/ethereum/engine: Unique Payload ID Tests #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might worth adding the case when a new withdrawal is appended to the list, this case is artificial but should be pretty easy to add. It seems like fuzzing for this kind of things should work well too in addition to regular tests. |
I'd really like to add fuzzing to hive, and my main deterrent is that hive tests are already flaky on their own, so adding fuzzing will make this worse, but it's something I'll keep in mind. I added the suggested test case @mkalinin |
mattsse
pushed a commit
to paradigmxyz/hive
that referenced
this pull request
May 12, 2023
* simulators/ethereum/engine: send `eth_` requests to port 8545 (ethereum#752) simulators/ethereum/engine: send `eth_` requests to 8545 * clients/ethereumjs: Update branch (ethereum#753) * clients/ethereumjs: Change git branch * clients/ethereumjs: Fix bash script issues * simulators/ethereum/engine: node: unsubscribe from events * simulators/ethereum/engine: clmock: add extra logs * simulators/ethereum/engine: correctly stop secondary clients * simulators/eth2/common: create client interfaces, update mock builder (ethereum#738) * simulators/eth2/common: refactor clients * simulators/eth2/engine: fixes due to refactor * simulators/eth2/common: builder: invalidate payloads * simulators/eth2/common: builder readme * simulators/eth2/common: builder: add option to build a payload on an outdated version * simulators/eth2/withdrawals: add invalid built payload version test * simulators/eth2/common: builder: remove check to build invalid payload * simulators/eth2/withdrawals: Fix check * simulators/eth2/withdrawals: test case validation * simulators/eth2/common: builder: fix invalidation * simulators/eth2/withdrawals: fix verifications again * simulators/ethereum/pyspec: Comment Dockerfile to run local fixtures (ethereum#755) simulators/ethereum/pyspec: Add Dockerfile comment to run locally generated fixtures * clients/besu: add --data-storage-format=BONSAI (ethereum#758) * simulators/ethereum/engine: Unique Payload ID Tests (ethereum#757) * simulators/ethereum/engine: expose generic fcu, np * simulators/ethereum/engine: Unique payload id test * simulators/ethereum/engine: Add payload id test * simulators/ethereum/engine: Parallel getPayloadBodies Test (ethereum#749) * simulators/ethereum/engine: parallel getpayloadbodies * simulators/ethereum/withdrawals: readme * clients/erigon: --externalcl flag is not supported anymore (ethereum#760) * graphql: consistent rule for Long outputs and args (ethereum#746) * simulators/eth2: Verify block signatures on blocks sent to builder (ethereum#756) * simulators/eth2/common/builder: interfaces changes * simulators/eth2/common/builder: verify signatures * simulators/eth2/withdrawals: Verify block signatures * simulators/eth2/withdrawals: Update README * simulators/eth2/withdrawals: minor nit comment * clients/erigon: explicit --db.size.limit value (ethereum#766) * clients/nethermind: Cancun support (ethereum#762) * clients/nethermind: Cancun Support * clients/nethermind: Dockerfile args * clients/besu: Cancun Support (ethereum#769) * clients/ethereumjs: Cancun Support (ethereum#768) clients/ethereumjs: Cancun Support. * clients/go-ethereum: remove deprecated PoW (ethereum#773) Remove ethash-related flags and utils from go-ethereum, since they were deprecated upstream. --------- Co-authored-by: Martin Holst Swende <martin@swende.se> * clients/nethermind: Add excessDataGas to genesis mapper. (ethereum#771) * sim/pyspec: bubble error (ethereum#777) * simulators/devp2p: fix issue causing ethereumjs to crash (ethereum#778) sim/devp2p: fix issue causing ethereumjs to crash It seems ethereumjs crashes if the chainid is not present in the genesis. --------- Co-authored-by: Mario Vega <marioevz@gmail.com> Co-authored-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com> Co-authored-by: Sina Mahmoodi <1591639+s1na@users.noreply.github.com> Co-authored-by: Spencer Taylor-Brown <spencer@spencertaylorbrown.uk> Co-authored-by: Martin Holst Swende <martin@swende.se>
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements test for ethereum/execution-apis#401
cc @mkalinin