Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hiveview: Client URL based filtering #862

Closed

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Sep 12, 2023

Adds a small change to filter all the simulations within index.html based on the client provided within the url.

For example, now /?client=go-ethereum will display only simulations by geth. This acknowledges that client names within simulation logs usually include extra metadata such as go-ethereum_cancun-git, hence the value specified in the url is matched against the string before the first _.

Client teams can now bookmark their specific simulations: https://hivecancun.ethdevops.io/?client=go-ethereum

@spencer-tb spencer-tb marked this pull request as ready for review September 12, 2023 12:41
@marioevz marioevz requested a review from fjl September 12, 2023 14:58
@fjl
Copy link
Collaborator

fjl commented Sep 14, 2023

I've implemented a more complete version of this in #864. Please try it. Main advantage of my thing is that you get a way of creating the URL by changing the select, whereas with this PR, you just sort of have to know that it can be filtered by URL.

However, my solution doesn't do the substring match.

@spencer-tb
Copy link
Contributor Author

Closing in favor of #864!

@spencer-tb spencer-tb closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants