Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

__INTEL_COMPILER #67

Merged
merged 1 commit into from Apr 4, 2016
Merged

__INTEL_COMPILER #67

merged 1 commit into from Apr 4, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2016

Error #396

@ghost
Copy link
Author

ghost commented Apr 2, 2016

reviewed libweb3core #defines:

libweb3core\libdevcore\Common.cpp: removed defines
libweb3core\libdevcore\RLP.cpp: removed defines
libweb3core\libdevcore\Common.h: ifdef __INTEL_COMPILER: disable warning 3682
libweb3core\libdevcore\vector_ref.h: ifdef __INTEL_COMPILER: disable warning 597
libweb3core\libdevcore\CommonData.h: ifdef __INTEL_COMPILER: template function toBigEndian
libweb3core\libdevcore\RLP.h: ifdef __INTEL_COMPILER: template function pushInt

bobsummerwill
bobsummerwill reviewed Apr 2, 2016
View reviewed changes
libdevcore/Common.cpp
@@ -94,7 +94,7 @@ string inUnits(bigint const& _b, strings const& _units)
auto i = *it;
if (i != _units.front() && b >= unit)
{
ret << (double(b / (unit / 1000)) / 1000.0) << " " << i;
ret << (b.convert_to<double>() / (unit.convert_to<double>() / 1000) / 1000.0) << " " << i;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the 1000 should be 1000.0, shouldn't it?

@ghost
Copy link
Author

ghost commented Apr 3, 2016

within the top-level template function, any use of the convert_to function throws an error:

/home/libweb3core/libdevcore/CommonData.h(121): error: type name is not allowed
        o_out[i - 1] = (typename Out::value_type)(uint8_t)(v.convert_to<uint8_t>());

@bobsummerwill bobsummerwill mentioned this pull request Apr 3, 2016
Closed
__INTEL_COMPILER
0eea94e 
minimize changes
@bobsummerwill bobsummerwill merged commit 4ac15c5 into ethereum:develop Apr 4, 2016
This was referenced Aug 26, 2016
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobsummerwill @chriseth