Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

[ESLint] update 'scripts' #1539

Merged
merged 5 commits into from
Dec 22, 2016
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ settings:
import/core-modules: ## don't lint for these missing packages in package.json
- electron ## 'electron' is only needed as devDependency / global installation


rules:
# "off" or 0 - turn the rule off
# "warn" or 1 - turn the rule on as a warning (doesn’t affect exit code)
Expand All @@ -23,6 +22,10 @@ rules:
comma-dangle:
- error
- only-multiline
import/no-extraneous-dependencies:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a explanation of what these rules do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments!

- error
- devDependencies:
- "**/*.test.js"

globals: # don't warn about missing declarations
i18n: true
Expand Down
2 changes: 2 additions & 0 deletions scripts/build-dist.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/usr/bin/env node
/* eslint-disable import/no-extraneous-dependencies */

const builder = require('electron-builder');
const shell = require('shelljs');
const Q = require('bluebird');
Expand Down