Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

should fix #1701 #1718

Closed
wants to merge 3 commits into from
Closed

should fix #1701 #1718

wants to merge 3 commits into from

Conversation

frozeman
Copy link
Contributor

@frozeman frozeman commented Mar 9, 2017

should fix #1701. This decreases the cache for arm and 32 bit architectures.

@mention-bot
Copy link

@frozeman, thanks! @luclu, @evertonfraga and @alexvandesande, please review this.

@@ -359,7 +359,7 @@ class EthereumNode extends EventEmitter {
// START MAINNET
else {
args = (nodeType === 'geth')
? ['--fast', '--cache', '1024']
? ['--fast', '--cache', ((process.arch == 'x64') ? '1024' : '512')]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use '===' ;-)

@luclu
Copy link
Contributor

luclu commented Mar 9, 2017

Doesn't work for me:

bildschirmfoto 2017-03-09 um 11 36 28

@frozeman
Copy link
Contributor Author

@lucu can you please check the logs in the console, as well as the terminal so i can figure out whats going on on your side? Also OS etc would be great.
Your issue otherwise not really helping ;)

@luclu
Copy link
Contributor

luclu commented Mar 11, 2017

Sorry @frozeman, here is a comparison of develop (working, left) and this branch.
They are virtually the same. On macOS 10.12.3 as well as on Ubuntu 16.04.

bildschirmfoto 2017-03-11 um 14 43 32 kopie

@frozeman
Copy link
Contributor Author

I don't think that has to do with these changes in they PR as they probable change nothing for your setup. Could you get a clean clone? seems like something on your system is broken?

@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OOM geth crash - sync stops at 2% and Ether no showing
4 participants