-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
…into add-rinkeby-support
…into add-rinkeby-support
@@ -46,7 +46,7 @@ | |||
</p> | |||
|
|||
{{#if TemplateVar.get "testnet"}} | |||
<p>{{{i18n "mist.popupWindows.onboarding.mineItDescription"}}}</p> | |||
<p>{{{i18n "mist.popupWindows.onboarding.FaucetDescription"}}}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have made that camelCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frozeman done.
@@ -81,7 +90,7 @@ Template['popupWindows_onboardingScreen'].helpers({ | |||
|
|||
@method syncStatus | |||
*/ | |||
'syncStatus': function () { | |||
syncStatus() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats ES6 right here, if we would remove the ecmascript package, this would break.
else { | ||
switch (network) { | ||
// STARTS ROPSTEN | ||
case 'test': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we call this "test" and the other by its name? To be backwards compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some reasons:
- backwards compatibility, yes
- Geth refers to the networks as
--testnet
and--rinkeby
, so we're actually being consistent with their flags - forward compatibility: that'll work even if the testnet flag changes to a different chain, so we're not being specific to Ropsten in the internals, only when it's displayed.
I didn't test it on my machine, but it looks good from the code changes. |
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
As a bonus, user can also choose a local private network.