Transaction receipt contractAddress injection

[evertonfraga]

What does it do?

Overrides eth_getTransactionReceipt to properly add contractAddress.

It comes in handy as the light client currently doesn't return that for now.

[evertonfraga]

TODO: add support to batch requests

[ghost]

Thank you for this, can you explain how to use it?

[evertonfraga]

@ni2k10 you can try to build Mist from source, or wait for a release, that will happen ~2 days after this has been merged.

[bliekp]

Please merge this ASAP. This is a real showstopper and it would be great if this is fixed...

[evertonfraga]

Working on it.

…

On Mon, 13 Nov 2017 at 16:48 Pim Bliek ***@***.***> wrote: Please merge this ASAP. This is a real showstopper and it would be great if this is fixed... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3265 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC4BN8Ft1uNH7tVxu_jr699oPnBNrZ_ks5s2LkrgaJpZM4QYvvc> .

[wolovim]

successfully resolves hanging contracts in tandem with ethereum/meteor-dapp-wallet#427

[pokjs]

@@ -0,0 +1,60 @@
+const _ = global._;
+const BaseProcessor = require('./base');
+const eth = require('ethereumjs-util');
+
+/**

• • Process method: eth_getTransactionReceipt
• */

+module.exports = class extends BaseProcessor {
+

• sanitizeRequestPayload(conn, payload, isPartOfABatch) {

•    return super.sanitizeRequestPayload(conn, payload, isPartOfABatch);
  

• }
• async exec(conn, payload) {

•    const txHash = payload.params[0];
  

•    // Sends regular eth_getTransactionReceipt request
  

•    const ret = await conn.socket.send(payload, {
  

•        fullResult: true
  

•    });
  

•    // If that contains a contractAddress already, fine.
  

•    if (ret.result.result.contractAddress != null) {
  

•        return ret.result;
  

•    }
  

•    // Due to a geth's light client v1 bug, it does not return
  

•    // contractAddress value on the receipts. Let's fix that.
  

•    // 1. GET TRANSACTION from AND nonce VALUES
  

•    const transactionInfo = await conn.socket.send({
  

•        jsonrpc: '2.0',
  

•        id: _.uuid(),
  

•        method: 'eth_getTransactionByHash',
  

•        params: [txHash]
  

•    }, { fullResult: true });
  

•    const fromAddress = transactionInfo.result.result.from;
  

•    const nonce = parseInt(transactionInfo.result.result.nonce, 16);
  

•    const possibleContractAddress = `0x${eth.generateAddress(fromAddress, nonce).toString('hex')}`;
  

•    // 2. GET CODE FROM ADDRESS
  

•    const contractCode = await conn.socket.send({
  

•        jsonrpc: '2.0',
  

•        id: _.uuid(),
  

•        method: 'eth_getCode',
  

•        params: [possibleContractAddress, 'latest']
  

•    }, { fullResult: true });
  

•    const contractCodeResult = contractCode.result.result;
  

•    // 3. IF IT EXISTS, ASSIGN TO RETURN VALUE
  

•    if (contractCodeResult && contractCodeResult.length > 2) {
  

•        ret.result.result.contractAddress = possibleContractAddress;
  

•    }
  

•    return ret.result;
  

• }
  +};

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.