Possibility to specify IPC path & RPC over HTTP support #420
Conversation
|
I will first merge @hiddentao PR and will then look at yours. |
Conflicts: main.js
|
Can you rebase your changes on develop? |
Conflicts: main.js modules/ipc/ipcProviderBackend.js modules/ipc/nodeConnector.js
|
Would be nice to get this one in. |
| @@ -9,8 +9,12 @@ const log = require('../utils/logger').create('getIpcPath'); | |||
|
|
|||
| module.exports = function() { | |||
| var p = require('path'); | |||
| var path = global.path.HOME; | |||
| var providedPath = global.rpcUri; | |||
There was a problem hiding this comment.
why you create this variable here? Why not simply if(global.rpcUri) ?
…g http connection
|
Thanks for comments. Updated the PR. Any hint what might be wrong with: |
|
Try timeout with 0 or 1 instead of 50. But not sure what could cause this. I will have a look if i find time |
|
@hiddentao I can't assign you this issue, but I'll leave this to you. Can you please review, and solve the merge issues? If you consider it useful then I'll merge it |
Conflicts: modules/ipc/ipcProviderBackend.js
|
Merged latest |
|
Sure I'll take a look at this. Actually my other PR changes a whole bunch of stuff so this might need some rewrites anwway. I hope to have that PR ready for review tomorrow. |
|
I think I'd like to take these changes one a time, so first merge in #601 to enable custom IPC paths. And then look at the possibility of a non-IPC connection to geth, as enabled by the #559 introduces a dedicated |
|
@hiddentao have your changes made this one redundant? |
|
Not quite. This one also suggest enabling the use of HTTP instead of IPC for RPC purposes. That part is still not integrated into our code. -- Director http://hiddentao.com On 2 June 2016 at 03:57:44, Alex Van de Sande (notifications@github.com) wrote: @hiddentao have your changes made this one redundant? — |
|
Good idea would be to popup a warning message when user's use a HTTP connector, informing them that it's more risky than IPC. |
|
Replaced by #871 |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Based on #393
--rpccli option)net.Socketwhich uses HTTP as a transport.I would really love to get rid of that: https://github.com/ethereum/mist/compare/develop...tomusdrw:rpc?expand=1#diff-a31b48952900046cc9945315da84b939R22
It seems that the responses are stuck somewhere if the requests are sent synchronously (
setImmediateor lower timeouts are also not sufficient). But the response is genererated by server and also quiting the application causes the response to be received and processed (sic!). Any hints?