This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Remove old, redundant code #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aren't we using popupWindow.js for launching the new accounts page? |
|
I refactored that all into |
|
Yes, tested and it works. Will wait for a bit for another 👍 and eventually merge it |
|
Sorry guys this PR/(branch) disabled the import-dialog for me. Also I don't get any onboarding screen on a vanilla osx (I moved I don't know that much about branching strategies, but the current process either is a mess or it is just confusing me 😞. Update: |
|
@luclu I wonder if some cacheing is involved in the issues you're having, thought I can't think where the cache might be. |
|
I didn't have any of these problems Luca |
alexvandesande
pushed a commit
that referenced
this pull request
Jun 15, 2016
* Remove old git diff tags * updated nodes (#655) * Upgrade code to work with Electron 1.0.1 (#651) * Remove old git diff tags * fix code to work with Electron 1.0.1 * Korean Translation (#645) * Create app.kr.i18n.json Korean Translation * Create mist.kr.i18n.json * Update app.kr.i18n.json * Added mist.kr.i18n.json Added Korean Translation * Added Korean Translation - app.kr.i18n.json Added Korean Translation * Added Korean Translation -app.kr.i18n.json Added Korean Translation * Added Korean Translation - mist.kr.i18n.json Added Korean Translation * Added Korean (kr) Added Korean (kr) * fixed few Korean translation fixed few Korean translation * Update app.kr.i18n.json * Update mist.kr.i18n.json fixed some Korean translation * fixed linux32 node path and binary (#665) * Node startup and synchronization improvements (#559) * remove commented-out code, cleanup * work towards new socket system and ethereum nodes manager * main: work towards finishing up node connection * refactored node start code * remove old ethereum nodes code * get basic IPC connection to geth working * rename socket to sockets * - shift all node startup code into ethereumNode - remove nodeConnector, shift its functionality into ethereumNode - redo checkNodeSync to be more robust * nodeSync needs to be able to emit events * fixed a number of bugs, and finished sync rewrite. now need to test * basic sync working * slow down the sync check * check that onboarding followed by sync works for testnet * better log msgs, reduce socket disconnection timeout, fix bug * sync is much more resilient now and auto-restarts if node changes * ensure that switching network works once app is loaded * add node 4 dep * Fix menu items code * improve tab resetting logic to happen before Mist crashes * fix how we detect whether eth has started up, remove nodeConnector * ensure can switch network type while syncing * - Make sure it works when using Geth 1.4 (tested the Darwin x64 version). - We now show network info in top-right of both splash screen and onboarding window * Improved how we determine splash screen status messages. Now much more responsive to underlying connection process. * Remove old git diff tags * build windows management architecture, to avoid 'window already destroyed' errors * replace popupWindow with Windows manager interface * remove peer search timeout functionality and simplify splash screen logic * remove now-redundant meteor package * fix bugs and issues for electron 1.0 support * got tx sending working again * rename IPC message types * added i18n support to networkIndicator element, added better highlighting * dont auto-exit if startup fails - show logging info instead * fix bug preventing distributable build * fixes for electron 1.0, get wallet distributable working * remove old redundant code * Check for node startup error (#673) * Remove old git diff tags * check for geth fatal startup error * more helpful error message if geth unable to bind to port * UI Changes to network indicator (#675) * untracked public/i18n (#692) * small typo: some_where (#693) * Remove old, redundant code (#674) * Remove old git diff tags * remove old redundant code * Integrate #601 along with some improvements to IPC Path * Remove old git diff tags * integrate #601 * check for geth fatal startup error * remove old redundant code * UI Changes to network indicator * merge * updates nodes to 1.4.5 * update the menu string * Pass custom CLI options to the Ethereum node (#689) * integrate #601 * better cli arg parsingj * better cli arg parsingj * Simplify cliArgs API. * update readme * fix bug * Nav bar glitch and new art for Mist (#696) * Solves navbar glitch and adds new icon and splash screen art * adds new splash screen art for Mist * added a yellow tint to the image * added node linux 32 (#711) * added unlock and send (#700) * Check for update at startup and inform the user if a new version is available (#707) * refactor globals setup by preloader * final version of update checker mechanism * if in mist mode search for a mist update * replace image ids with better system * Remove dependency on node log output for detecting startup success (#706) * remove dependency on node log output for detecting startup success * only start the startup timeout once some data has been received * Norwegian Bokmål translation (#705) * bump version to 0.7.5 * Upgrade to web3 version in order to fix broken Send tx funtionality * update web3 to npm version * Suggestions and misspelling (#753) A few suggestions for a slightly less informal translation. * fixed preloader scripts * changed file permissions back * changed file permissions back * Fix Mist/Wallet app bundling (#721) * fix Mist/Wallet app bundling * update electron-packager to 7.0.2 * Minor changes (#769) Formal used also in the error message. * Full translation in italian (#768) File has been translated in Italian. * start ci * trigger build * only build on node 4g * fix deps * test develop branch * added alex and fabian to notification list * corrected %appdata% path in readme (#776) * Refactoring Dapp IPC connection (#724) * work towards new ipc backend wrapper * work towards refactoring ipc provider backend * work towards refactor * work towards refactoring request processing * work towards new ipc backend wrapper * work towards refactoring ipc provider backend * work towards refactor * work towards refactoring request processing * improved web3ipcsocket logic, work towards request/response processing in provider backend * split per-method handlers into separate files, dynamically loaded. - fixed web3 ipc socket response handlng - finalized sendRequest() initial draft * rename generic to base - fix bugs in use of socket * enforce timeout of 0 for sockets * work towards handling batch requests * remove old provider backend * fix batch result parsing * fix numerous bugs, improve how window id gets set * remove redundant error * have a connection per webview rather than per-window * defensive coding * adds default wallet hosted by github (#767) * adds default wallet hosted by github * change to ethereum.org page, adds id to avoid inserting multiple times * new icon * Refactor splash screen (#772) * Refactoring of the splash screen * center the checking network message * Show Start App button sooner * update geth to 1.4.6 + win32 support (#784) * update travis notification email addr * Fix problem with geth node being detached (#789) * fix node detaching, improve socket ipc backend connector * launch app link should show straight away * fix bug * Changes to onboarding screen (#786) * Fix bug that was preventing onboarding to start * allows account creation to be skipped and checks passwords * skip account page * Added number animation to blocknumbers * speed down to prevent hanging * removes log and adds comments to code * only math.floor the display block not the actual number * adds shapeshift reference * fix handling of array results * fix handling of results - ensure json result is always set * readme: beautify privatenet ipcpath * fix remaining issues * ensure error reponse doesn't include method and params * upgrade to electron 1.2.2 * Fix the testnet label alignment (#792) * fix the testnet label alignment * on the onboarding, just show states as percentage * fix web3.isConnected() issue * fixes issue where onboarding screen would not appear * fixed dragging * adds a drag region to the mist sidebar (#820) * download nodes * added download-nodes * remove unecessary packages * remove unecessary drags * added gulp update nodes to travis * Update menu items label * update eth to 1.2.9 (#825)
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old, redundant code.