fixed #553, adding setting to change UI language

[ChihChengLiang]

Dear developers,

Thanks for the awesome project. To address #553 , I added a menu item "settings" that users can change languages in the wallet screen easily.
Note that the language of the app menu can't be changed with this feature, at the moment I can't figure out yet. Hints would be appreciated.

Warm regards,
Chih-Cheng

---

update:
successfully changed the language of the app menu.

[frozeman]

You would need to call ipc.send('backendAction_setLanguage', lang_code); after this line. This should change the menu language

[ChihChengLiang]

Thanks for the hint, @frozeman. However I failed calling ipc.send both in menuItem.js and in webpage.
First attempt:

        click: function(){
                let mainWindow = Windows.getByType('main');
                mainWindow.webContents.executeJavaScript(
                    `TAPi18n.setLanguage('${lang_code}');`
                );
                ipc.send('backendAction_setLanguage', lang_code);
            }

which gives

TypeError: ipc.send is not a function
    at menuItem.click (/home/chihchengliang/ether/mist/modules/menuItems.js:444:21)
    at MenuItem.click (/home/chihchengliang/npm-global/lib/node_modules/electron-prebuilt/dist/resources/electron.asar/browser/api/menu-item.js:81:16)
    at Function.delegate.executeCommand (/home/chihchengliang/npm-global/lib/node_modules/electron-prebuilt/dist/resources/electron.asar/browser/api/menu.js:119:40)

in electron console and crashed. Checked the doc, ipcMain has no function send. It seems I can't send from main process.
Seeing ipc.send can be called from popWindow, I also tried sending from the webpage:

                mainWindow.webContents.executeJavaScript(
                    `TAPi18n.setLanguage('${lang_code}');
                    ipc.send('backendAction_setLanguage', '${lang_code}');`
                );

which throws Uncaught ReferenceError: ipc is not defined in browser console.

[ChihChengLiang]

Since ipcMain is an eventsEmitter class, the event can be triggered via emit function from ipc instance. e.g.

ipc.emit('backendAction_setLanguage', {}, lang_code);

see doc for more detail.

[frozeman]

Concerning the menu, i think view is better suitable for that. What you think @alexvandesande @hiddentao ?

[hiddentao]

Yep, sounds good to me.

On 14 June 2016 at 18:37:07, Fabian Vogelsteller (notifications@github.com) wrote:

Concerning the menu, i think view is better suitable for that. What you think @alexvandesande @hiddentao ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[hiddentao]

Language switching works, though for some languages (e.g. kr) no change is seen in the wallet UI as far as I can see. This is likely due to missing translations.

[atomrigs]

@hiddentao It seems Korean the language code is "ko", not "kr",

[ChihChengLiang]

hi @hiddentao ,
kr works perfectly for me.
nb and zh failed to change because wallet.nb.i18n.json and wallet.zh.i18n.json don't exist.
es failed to change too, though wallet.es.i18n.json is partially translated.

[atomrigs]

I made PR for changing Korean code from kr to ko
#835
ethereum/meteor-dapp-wallet#224

[alexvandesande]

One of my language codes is set at "Dev" which is not functional. Also there should be a first item called "auto" that reverts back to the default

[ChihChengLiang]

hi @alexvandesande , the Dev item removed and a first item auto added as desired.
hi @frozeman , the language of the menu bar can be successfully changed now.
I also rebased this branch on develop so that @atomrigs 's modification of Korean i18n can be tested.
Thanks all you guys' support as well as @hiddentao 's review.

[ChihChengLiang]

hi, in case anyone get confused, the required feature in this PR is completely implemented and ready for review. Let me know if anything need to modified or improved. Thanks :)

[luclu]

Let me clean up the lang codes today. ;)

update: done - #889.
@ChihChengLiang I added some missing to project-tap.i18n.

It would be great to get rid of the wallet-requirement so this won't cause trouble with Mist-users - @alexvandesande {edit: "what do you think"}?

nb and zh failed to change because wallet.nb.i18n.json and wallet.zh.i18n.json don't exist.
es failed to change too, though wallet.es.i18n.json is partially translated.

[alexvandesande]

I've done some work on this PR too but couldn't have it uploaded due to the other urgent issues. Will upload the changes as soon as I can.

Btw: clicking on "auto" does nothing for me

On Jun 25, 2016, at 07:19, Luca Zeug notifications@github.com wrote:

Let me will clean up the lang codes today. ;)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[ChihChengLiang]

hi,
@luclu Thanks!

@alexvandesande : the auto button works now. It'll use electron built-in app.getLocale to get system locale when triggered.

[alexvandesande]

I included these changes here: #896

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.